Don't clear lock link database during analysis. #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we clear the database and a resolve back-tracks, we lose the additional artifact urls needed to fill in the backtracked requirement lock encountered later in the resolve. Previously the clearing was done to relieve memory pressure during the analysis but measurements show even moderately large resolves collect only a handful of MBs worth of link data. We could collect 100x more links in a very large resolve and still be OK here on all but the most constrained machines. As such, we simply stop clearing the crawled link database during analysis. Fixes pex-tool#1711
benjyw
approved these changes
Apr 8, 2022
Eric-Arellano
approved these changes
Apr 8, 2022
No clue why this works under Python 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we clear the database and a resolve back-tracks, we lose the
additional artifact urls needed to fill in the backtracked requirement
lock encountered later in the resolve.
Previously the clearing was done to relieve memory pressure during the
analysis but measurements show even moderately large resolves collect
only a handful of MBs worth of link data. We could collect 100x more
links in a very large resolve and still be OK here on all but the most
constrained machines. As such, we simply stop clearing the crawled link
database during analysis.
Fixes #1711